test: update test to use fixtures module #15955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the test-http2-create-client-connect tests to use the test fixures module instead of the common module.
Trott
added
the
code-and-learn
BridgeAR
approved these changes
Oct 7, 2017
tniessen
approved these changes
Oct 7, 2017
cjihrig
approved these changes
Oct 7, 2017
trivikr
approved these changes
Oct 7, 2017
targos
approved these changes
Oct 8, 2017
|
Landed in 5ca1c7a, thanks for the contribution and welcome to Node.js! |
joyeecheung
pushed a commit
that referenced
this pull request
Oct 8, 2017
Updated the test-http2-create-client-connect tests to use the test fixures module instead of the common module. PR-URL: #15955 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Updated the test-http2-create-client-connect tests to use the test fixures module instead of the common module. PR-URL: #15955 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Updated the test-http2-create-client-connect tests to use the test fixures module instead of the common module. PR-URL: nodejs/node#15955 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the test-http2-create-client-connect tests to
use the test fixures module instead of the common
module.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test